[Bug 756567] Wayland crash when called from gstreamer

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=756567

George Kiagiadakis <george.kiagiadakis at collabora.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #11 from George Kiagiadakis <george.kiagiadakis at collabora.com> ---
commit c2f34b981427f2698ce47195627a40894b640962
Author: George Kiagiadakis <george.kiagiadakis at collabora.com>
Date:   Mon Oct 26 15:30:08 2015 +0100

    waylandsink: don't advertise the local wl_display context

    This wl_display proxy is temporary only until waylandsink goes NULL,
    at which point the connection to the display is disposed. Unfortunately,
    if this is advertised as a GstContext, playbin will cache it and re-feed
    it to the sink when it goes PLAYING again, but the wl_display pointer
    will at that point be invalid and cause a crash.

    Another solution to the problem would be to also cache the GstWlDisplay
    object inside the GstContext, which would automatically ref-count
    the display connection, but I see no reason in doing that at the moment,
    as there are no known users of this GstContext outside waylandsink.
    It's probably better to avoid chasing hidden refcounts.

    https://bugzilla.gnome.org/show_bug.cgi?id=756567

-- 
You are receiving this mail because:
You are the QA Contact for the bug.