[Bug 733959] hlsdemux: download bitrate algorithms don't reflect real download rate

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=733959

Thiago Sousa Santos <thiagossantos at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #313935|none                        |needs-work
             status|                            |

--- Comment #41 from Thiago Sousa Santos <thiagossantos at gmail.com> ---
Review of attachment 313935:
 --> (https://bugzilla.gnome.org/review?bug=733959&attachment=313935)

+1 on this approach. Some minor remarks below.

::: gst-libs/gst/adaptivedemux/gstadaptivedemux.c
@@ +89,3 @@
 #define DEFAULT_CONNECTION_SPEED 0
 #define DEFAULT_BITRATE_LIMIT 0.8
+#define SRC_QUEUE_MAX_BYTES 20 * 1024 * 1024    /* For safety. Large enough to
hold a segment. */

This is going to bite us some day, it would be nice to connect to the overrun
signal on queue2 at least to print or post a warning so it is easy to identify
in the future when the measure would be disturbed by this size.

* queue2 doesn't have the overrun, it would need to be implemented. Can likely
be copied from queue.

@@ +1875,3 @@
+    queue_sink = gst_element_get_static_pad (queue, "sink");
+
+    if (GST_PAD_LINK_FAILED (gst_pad_link (uri_handler_src, queue_sink))) {

This link should never fail hierarchy or caps check, perhaps just use
gst_pad_link_full and disable those checks.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.