[Bug 750847] dashdemux: variables containing time information should be guint64 not gint64

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=750847

--- Comment #26 from Florin Apostol <florin.apostol at oregan.net> ---
Review of attachment 314382:
 --> (https://bugzilla.gnome.org/review?bug=750847&attachment=314382)

::: ext/dash/gstmpdparser.c
@@ +979,3 @@
+          GST_WARNING ("'-' sign found while parsing unsigned duration");
+          goto error;
+        }

if negative durations are accepted, this is not where the '-' sign should be.
It should be before P.

If we do not need to support parsing negative durations, I suggest doing a
single search at the beginning. If we do want to support parsing negative
durations, the original code did it ok: search for the first occurrence, test
that it is at the beginning, search again for a second occurrence that should
not exist.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.