[Bug 754356] event: Make sure that timestamp + diff in QoS events is never smaller than 0

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Tue Sep 1 00:09:06 PDT 2015


https://bugzilla.gnome.org/show_bug.cgi?id=754356

--- Comment #3 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
This is both not ideal yet btw, but it works.

The first patch will put an arbitrary timestamp into the event, which together
with the diff will lead to timestamp+diff=0. This causes less hard failures
than before (integer overflow, so timestamp+diff was a huge number and
everything was too late) but makes elements believe that now would be a good
time to produce something for timestamp 0... which might just be what they
currently produce.

That leads to the second patch, where aggregator told newly added sinkpads with
pad offsets in use somewhere that timestamp 0 is the earliest time now. And the
first buffer was dropped because it had timestamp 0 (checks for dropping are
buffer_running_time <= timestamp + diff).

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list