[Bug 752694] rtpmux: allow the ssrc-property to decide ssrc on outgoing buffers

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=752694

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #310389|none                        |reviewed
             status|                            |

--- Comment #15 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 310389:
 --> (https://bugzilla.gnome.org/review?bug=752694&attachment=310389)

Looks mostly good and the approach makes sense IMHO

::: gst/rtpmanager/gstrtpmux.c
@@ +231,3 @@
+
+          while (ssrc == rtp_mux->current_ssrc)
+            rtp_mux->current_ssrc = g_random_int ();

This can probably use a mutex somewhere. The upstream event is not necessarily
coming from our streaming thread, and we might put some transient ssrc on some
buffers that is not the same as the one in the caps.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.