[Bug 743657] dvdemux: no tags for .dv files

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=743657

Thiago Sousa Santos <thiagossantos at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #308993|none                        |needs-work
             status|                            |

--- Comment #20 from Thiago Sousa Santos <thiagossantos at gmail.com> ---
Review of attachment 308993:
 --> (https://bugzilla.gnome.org/review?bug=743657&attachment=308993)

::: ext/dv/gstdvdemux.c
@@ +306,3 @@
+  gst_tag_list_set_scope (tags, GST_TAG_SCOPE_GLOBAL);
+
+  if (dv_get_recording_datetime (dvdemux->decoder, rec_datetime)) {

You can create the taglist only if needed here, otherwise you end with an empty
one.

@@ +1222,3 @@
+      gst_pad_push_event (dvdemux->audiosrcpad, dvdemux->pending_tag_event);
+      dvdemux->pending_tag_event = NULL;
+    }

You can push the event directly on the add_pad function as the tag event is
sticky and will be forwarded once the pad is linked and data is pushed.

Also you can store the tag event in the demuxer and just push it again when a
new pad is needed, otherwise you will end up creating the same object twice
from scratch. Just remember to clean it up when doing from PAUSED to READY.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.