[Bug 754395] rtsp-media: prepare continues after error

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=754395

David Svensson Fors <davidsf at axis.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |davidsf at axis.com

--- Comment #1 from David Svensson Fors <davidsf at axis.com> ---
Created attachment 310419
  --> https://bugzilla.gnome.org/attachment.cgi?id=310419&action=edit
media: state handling updates

The attached suggested patch contains a fix for the problem (checking media
status before calling set_state() in start_preroll()) and some other fixes
concering the state lock in GstRTSPMedia:

* Check state errors in more places (protecting against concurrent
  updates).
* Protect set_state with state lock (except in finish_unprepare, where
  a comment explains that we release the lock for avoiding deadlocks).
* Consistently do convert_range with state lock held (as it says in
  the comment for default_convert_range).
* Clarify that default_prepare and default_setup_sdp are called with
  state lock.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.