[Bug 754429] basetextoverlay: crash in basetextoverlay for padding greater than video size

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=754429

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |slomo at coaxion.net
 Attachment #310458|none                        |reviewed
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Comment on attachment 310458
  --> https://bugzilla.gnome.org/attachment.cgi?id=310458
basetextoverlay: FIX crash if padding greater than video size

Thanks! :) This seems more like a workaround than a fix. If the overlay is
completely outside the video frame, it should not be rendered at all and have
width=height=0 instead of having a 1x1 pixel overlay somewhere.

That should be possible by just skipping some code, or doing an early return,
if width or height is <= 0.


Can you update the patch?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.