[Bug 754418] segment: Added gst_segment_position_from_stream_time()
GStreamer (GNOME Bugzilla)
bugzilla at gnome.org
Wed Sep 2 02:31:10 PDT 2015
https://bugzilla.gnome.org/show_bug.cgi?id=754418
Sebastian Dröge (slomo) <slomo at coaxion.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |slomo at coaxion.net
--- Comment #1 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
This is basically the equivalent to gst_segment_to_position(), which does the
same for a running time. I would rename gst_segment_to_position() to
gst_segment_position_from_running_time() and deprecate the old one to prevent
confusion and make it easier to find.
We could also call them gst_segment_running_time_to_position() (and
s/running_time/stream_time/), not sure if I prefer "from" or "to" in the
function name :)
Additionally all these functions need some unit tests.
gst_segment_to_running_time() and gst_segment_to_position(),
gst_segment_to_stream_time() and gst_segment_position_from_stream_time().
And especially gst_segment_to_running_time_full() needs some tests for the
special cases added in 1.6.
The tests for the ->position conversion functions could check if
position->(stream_time|running_time)->position gives the same values again.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list