[Bug 754429] basetextoverlay: crash in basetextoverlay for padding greater than video size

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=754429

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #310464|none                        |reviewed
             status|                            |

--- Comment #4 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Comment on attachment 310464
  --> https://bugzilla.gnome.org/attachment.cgi?id=310464
basetextoverlay: FIX crash if padding greater than video size

This looks better (and simpler) :) I'm just not sure if the checks should
actually be moved a bit further down, are at multiple places, or unscaled_*
should also be checked.

I didn't fully follow the code, but I saw that width and height are modified
further before the cairo_matrix_init_scale() and could possibly become at least
0 (not sure if negative) there.


I think we need to make sure that at no point we're calculating with negative
numbers (and if they happen we can just ignore rendering), and if width or
height are 0 before the cairo_matrix_init_scale() we can also stop rendering
anything.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.