[Bug 754457] segment: Rewording of struct field descriptions

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=754457

Tim-Philipp Müller <t.i.m at zen.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #310499|none                        |reviewed
             status|                            |

--- Comment #1 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
Comment on attachment 310499
  --> https://bugzilla.gnome.org/attachment.cgi?id=310499
Patch file

Some nitpicking

>- * @rate: the rate of the segment
>+ * @rate: the desired playback rate of the segment

It is the rate, not the "desired" rate. The desired rate is what you pass to
gst_event_new_seek().

>- * @applied_rate: the already applied rate to the segment
>+ * @applied_rate: the already applied rate to the stream

Why? It's not constant for the entire stream, but might change, no?



>- * @start: the start of the segment
>+ * @start: the start buffer timestamp of the segment
>- * @stop: the stop of the segment
>+ * @stop: the stop buffer timestamp of the segment

I think these might add more confusion actually, people might interpret it as
the timestamp of the first buffer, but the timestamp of the first buffer may be
before the start.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.