[Bug 754470] v4l2videodec: send decoder stop command instead of queueing empty buffers

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=754470

Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #310514|none                        |needs-work
             status|                            |

--- Comment #5 from Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> ---
Review of attachment 310514:
 --> (https://bugzilla.gnome.org/review?bug=754470&attachment=310514)

::: sys/v4l2/gstv4l2videodec.c
@@ +747,3 @@
+         */
+        self->queue_empty_buffers = FALSE;
+      }

Again, I don't see any reason to split the EOS handling in here.

@@ +835,3 @@
+
+  g_cond_init (&self->processing_cond);
+  self->queue_empty_buffers = TRUE;

Don't we already have a condition for waiting for the thread to stop ?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.