[Bug 754470] v4l2videodec: send decoder stop command instead of queueing empty buffers

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=754470

--- Comment #8 from Philipp Zabel <p.zabel at pengutronix.de> ---
(In reply to Nicolas Dufresne (stormer) from comment #5)
> Review of attachment 310514 [details] [review]:
> 
> ::: sys/v4l2/gstv4l2videodec.c
> @@ +747,3 @@
> +         */
> +        self->queue_empty_buffers = FALSE;
> +      }
> 
> Again, I don't see any reason to split the EOS handling in here.

Yes, now that you pointed it out it is quite obvious.

> @@ +835,3 @@
> +
> +  g_cond_init (&self->processing_cond);
> +  self->queue_empty_buffers = TRUE;
> 
> Don't we already have a condition for waiting for the thread to stop ?

I guess I could use
    GST_OBJECT_LOCK (decoder->srcpad->task);
    GST_TASK_WAIT(decoder->srcpad->task);
    GST_OBJECT_UNLOCK (decoder->srcpad->task);
in _dec_finish instead of adding this condition.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.