[Bug 754429] basetextoverlay: crash in basetextoverlay for padding greater than video size

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=754429

--- Comment #10 from Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> ---
Review of attachment 310561:
 --> (https://bugzilla.gnome.org/review?bug=754429&attachment=310561)

Checking both width/height and unscaled_widht/height is redundant, but not
faulty (it's extra safe). Otherwise the patch is correct. Obviously a unit test
in tests/check/element/textoverlay.c could be nice (so we have a test that
crash before, and works now).

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.