[Bug 744612] splitmuxsink: add property for specifing maximum number of files to store

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Sat Sep 5 07:07:55 PDT 2015


https://bugzilla.gnome.org/show_bug.cgi?id=744612

--- Comment #7 from Jan Schmidt <thaytan at noraisin.net> ---
Review of attachment 297407:
 --> (https://bugzilla.gnome.org/review?bug=744612&attachment=297407)

Mostly looks fine. It'll probably need a little merging with the later patches
that add a custom signal for apps to specify the next filename manually.

::: gst/multifile/gstsplitmuxsink.c
@@ +1507,3 @@
+  while (splitmux->max_files && splitmux->fragment_id >= splitmux->max_files)
{
+    splitmux->fragment_id = 0;
+  }

I think you mean 'if' instead of 'while' here.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list