[Bug 747495] gst_base_text_overlay_push_frame() doesn't make memory copy when video buffer's memory is ready only

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=747495

--- Comment #10 from Mingke Wang <mingke.wang at freescale.com> ---
(In reply to Nicolas Dufresne (stormer) from comment #8)
> Note that it would be nice if the text overlay does not do in-place when
> mapping the frame would lead to a copy. This way we could allocate from a
> downstream pool, but that's obviously more work.

I think one possible change could be  gst_buffer_make_writable().
now it will copy a new GstBuffer with new writable memory only when the
GstBuffer is read-only. 
We could add a case :
copy a new GstBuffer when (GstBuffer is writable && memory is read-only &&
memory can't be replaced)
that require add a new flag definition to GstBuffer flag like
GST_BUFFER_FLAG_MEMORY_NOT_REPLACEABLE

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.