[Bug 752415] dashdemux: provide a default suggestedPresentationDelay

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=752415

Vincent Penquerc'h <vincent.penquerch at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #310020|none                        |needs-work
             status|                            |

--- Comment #5 from Vincent Penquerc'h <vincent.penquerch at collabora.co.uk> ---
Review of attachment 310020:
 --> (https://bugzilla.gnome.org/review?bug=752415&attachment=310020)

::: ext/dash/gstdashdemux.c
@@ +372,3 @@
+      g_param_spec_string ("presentation-delay", "Presentation delay",
+          "Default presentation delay (in seconds or fragments) (e.g. 12s,
3f)",
+          DEFAULT_PRESENTATION_DELAY,

Should mention 'M' which the parsing function understands

@@ +456,3 @@
+    case PROP_PRESENTATION_DELAY:
+      g_free (demux->default_presentation_delay);
+      demux->default_presentation_delay = g_value_dup_string (value);

Seems to leak on object destruction

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.