[Bug 753613] mssdemux: PlayReady WRM parsing support
GStreamer (GNOME Bugzilla)
bugzilla at gnome.org
Mon Sep 7 03:59:39 PDT 2015
https://bugzilla.gnome.org/show_bug.cgi?id=753613
--- Comment #9 from Philippe Normand <phil at base-art.net> ---
(In reply to Tim-Philipp Müller from comment #8)
> Well, the {} stripping is not elegant, but that's string ops in C for you. I
> don't think using a regex will improve it much. You could also do something
> like, i.e. strip in place. If that's less code or nicer, I don't know. It
> doesn't really matter much imho.
>
> gsize id_len = strlen (system_id);
>
> if (system_id[id_len - 1] == '}') {
> system_id[id_len - 1] = '\0';
> --id_len;
> }
>
> /* move string one forward including the terminator */
> if (system_id[0] == '{')
> memmove (system_id, system_id + 1, id_len - 1 + 1);
>
Ok I can try with this. Thanks.
> Is the patch otherwise ready for review or is it still work in progress?
> ("started a patch" sounds like work in progress)
Yes it is ready for review but I suppose we have to wait anyway because git
master is frozen and this patch kind-of is a new feature rather than a critical
bugfix :)
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list