[Bug 754597] appsrc fails to push the caps at the start of the data flow when configured in seekable/random-access mode

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=754597

--- Comment #11 from Vikram Fugro <vikram.fugro at gmail.com> ---
Review of attachment 310868:
 --> (https://bugzilla.gnome.org/review?bug=754597&attachment=310868)

Thanks for the review. Will make the changes.

::: gst-libs/gst/app/gstappsrc.c
@@ +573,3 @@
     if (obj) {
+      if (GST_IS_CAPS (obj) && retain_last_caps &&
+          priv->last_caps == GST_CAPS (obj)) {

Yes, will decouple the usage of last_caps from here. 
It was just an extra check to be certain :)

BTW, Is gst_app_src_flush_queued() thread safe?
Shouldn't it be guarded by priv->mutex always?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.