[Bug 751735] dashdemux: incorrect parsing and handling of segment templates

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=751735

--- Comment #5 from Vincent Penquerc'h <vincent.penquerch at collabora.co.uk> ---
Review of attachment 306415:
 --> (https://bugzilla.gnome.org/review?bug=751735&attachment=306415)

The spec seems to forbid formatting not starting with 0. The code will allow
something like %3d, and
there are no tests with formats not starting with 0. We might want to allow
those anyway (in which
case, presumably not 0 padding). In general, I'm not sure it's such a good idea
to allow these things
(like u and x), because it may cause use of such templates by people not
realizing it's not standard,
thereby causing pressure on other implementations to start allowing those, etc.
No strong feeling
though. In any case, it needs either rejecting them, or a test for such.

::: tests/check/elements/dash_mpd.c
@@ +2173,3 @@
+    {"Time$Time%05xtest$", "Time00064test"},    /* %x format followed by text
*/
+    {"Time$Time%05xtest%$", NULL},      /* second % character in format */
+  };

Needs a test with %5 (ie, not starting with 0, which the spec mandates)
Needs a test with %0-4d (the spec says %0[width]d, want to catch parsing a
signed integer after the leading 0.
Maybe a test with a silly number. like %073843278d, and %0d too. Just to see if
we can break this code with a crafted template.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.