[Bug 752480] dashdemux: negative values for r attribute in S node are not supported

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=752480

--- Comment #4 from Florin Apostol <florin.apostol at oregan.net> ---
Review of attachment 310905:
 --> (https://bugzilla.gnome.org/review?bug=752480&attachment=310905)

::: ext/dash/gstmpdparser.c
@@ +297,3 @@
+  prop_string = xmlGetProp (a_node, (const xmlChar *) property_name);
+  if (prop_string) {
+  gboolean exists = FALSE;

sscanf returns EOF (-1) in case of an "input failure before any data could be
successfully interpreted".
For example, for strings containing spaces, or empty strings, sscanf returns
-1. You consider that a valid data.
You should check that the return code from sscanf is 1, not !0

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.