[Bug 751735] dashdemux: incorrect parsing and handling of segment templates

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=751735

--- Comment #8 from Florin Apostol <florin.apostol at oregan.net> ---
(In reply to Vincent Penquerc'h from comment #5)
> Review of attachment 306415 [details] [review]:
> 
> The spec seems to forbid formatting not starting with 0. The code will allow
> something like %3d, and
> there are no tests with formats not starting with 0. 
Fixed the code. Added tests.


> Needs a test with %5 (ie, not starting with 0, which the spec mandates)
Added test.

> Needs a test with %0-4d (the spec says %0[width]d, want to catch parsing a
> signed integer after the leading 0.
Added test.

> Maybe a test with a silly number. like %073843278d, and %0d too. Just to see
> if we can break this code with a crafted template.
Test for %0d already existed.
%073843278d is valid. I am not aware of on any limitations on the possible
range for the width parameter.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.