[Bug 751650] dashdemux: extra validations needed when parsing the representation element

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Fri Sep 11 02:57:18 PDT 2015


https://bugzilla.gnome.org/show_bug.cgi?id=751650

--- Comment #2 from Florin Apostol <florin.apostol at oregan.net> ---
Review of attachment 311096:
 --> (https://bugzilla.gnome.org/review?bug=751650&attachment=311096)

::: ext/dash/gstmpdparser.c
@@ +1449,3 @@
+
+  if (!has_duration && !has_timeline) {
+    GST_ERROR ("has: duration %d, timeline %d", has_duration, has_timeline);

this will always print "has: duration 0, timeline 0"
I suggest to replace it with "segment has neither duration neither timeline"

@@ +3150,1 @@
+    return ret;

remove this.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list