[Bug 754120] avdec_hevc: Segfault in hevc decode with glimagesink and AVX2 CPU feature

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=754120

--- Comment #25 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
(In reply to Tim-Philipp Müller from comment #24)
> Olivier suggested on IRC to move the loop that checks the alignments into a
> utility function. This means a caller would still have to do get_allocator()
> to get the AllocationParams and then call set_allocator() again if it was
> updated. It's the most transparent way of doing things though.

Is it going to be needed in many places (more than 2) that it makes sense to
have an utility function for it?

> Alternatively, one could also simply do all of this in
> gst_buffer_pool_config_set_video_alignment(). This means that the
> GstAllocationParams may change underneath the caller, which may or may not
> be a problem in practice. Needs to be documented I guess.

I think this should be handled explicitly by the caller of that API. The
fallback in videopool is IMHO just to prevent stupid mistakes and get a
GST_ERROR() out there while still doing something sensible that most likely
does not crash :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.