[Bug 750847] dashdemux: variables containing time information should be guint64 not gint64

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Mon Sep 14 03:25:05 PDT 2015


https://bugzilla.gnome.org/show_bug.cgi?id=750847

--- Comment #4 from Vincent Penquerc'h <vincent.penquerch at collabora.co.uk> ---
Turns out -1 is used implicitely as a "default" value for all "unsigned"
durations, passed via the default value on the parsing function, to be used
when the property is not present. Nothing seems to actually test for this after
the fact though. 0 would seem to be another possible default value, though 0
makes sense as a valid duration while -1 does not.

It's not quite clear what's the best to do here. The spec says at least some of
these durations are optional (eg, 5.3.2.1). I can't see code that checks
whether a period has a duration (which distinguishes between "regular" and
"early available" periods), so I'm guessing this is also missing. We end up
with a choice between keeping signed and -1 marker, or switching to unsigned
and having an extra flag (or, I guess switching to unsigned and using
G_MAXINT64 as a "not here" value).

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list