[Bug 752480] dashdemux: negative values for r attribute in S node are not supported

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=752480

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #310981|none                        |needs-work
             status|                            |

--- Comment #10 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 310981:
 --> (https://bugzilla.gnome.org/review?bug=752480&attachment=310981)

::: ext/dash/gstmpdparser.c
@@ +3765,3 @@
+  } else {
+    // 5.3.9.6.1: negative repeat means repeat till the end of the
+    // period, or the next update of the MPD (which I think is

Actually it does not say that :) It repeats until the next S at t of the next S
node, or if there is no next S node it repeats until the end of the period or
the next update of the MPD.

You're missing the check for the next S node, also in the other places

@@ +3766,3 @@
+    // 5.3.9.6.1: negative repeat means repeat till the end of the
+    // period, or the next update of the MPD (which I think is
+    // implicit, as this will all get deleted/recreated).

No C++/C99 comments

@@ +4148,3 @@
+      // negative repeats only seem to make sense at the end of a list,
+      // so this one will probably not be. Needs some sanity checking
+      // when loading the XML data.

No C++/C99 comments

@@ +4150,3 @@
+      // when loading the XML data.
+      if (segment->repeat < 0) {
+        GST_WARNING ("Negative repeat found on a non-end segment");

On a non-end segment, this means it repeats until the next S node's S at t

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.