[Bug 753196] audio/videoaggregator: Assumes that running time starts at seeking position after a seek (but it starts at 0 for flushing seeks)

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Mon Sep 14 10:57:38 PDT 2015


https://bugzilla.gnome.org/show_bug.cgi?id=753196

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
   Target Milestone|1.6.0                       |1.5.91

--- Comment #14 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Thanks!

commit 637106e2873c3ee32eb168dde464dac9971c942b
Author: Sebastian Dröge <sebastian at centricular.com>
Date:   Fri Sep 11 21:37:08 2015 +0200

    audioaggregator: Fix mixup of running times and segment positions

    We have to queue buffers based on their running time, not based on
    the segment position.

    Also return running time from GstAggregator::get_next_time() instead of
    a segment position, as required by the API.

    Also only update the segment position after we pushed a buffer, otherwise
    we're going to push down a segment event with the next position already.

    https://bugzilla.gnome.org/show_bug.cgi?id=753196

commit 97fe89f3518596ea10a6cbe5b09848d0948683d0
Author: Sebastian Dröge <sebastian at centricular.com>
Date:   Fri Sep 11 16:56:40 2015 +0200

    audioaggregator: Use stream time in the position query instead of segment
position

    https://bugzilla.gnome.org/show_bug.cgi?id=753196

commit eb97bb0adbd24f06c6bb32155b27bce995cd9a2d
Author: Sebastian Dröge <sebastian at centricular.com>
Date:   Fri Sep 11 12:22:51 2015 +0200

    videoaggregator: Fix mixup of running times and segment positions

    We have to queue buffers based on their running time, not based on
    the segment position.

    Also return running time from GstAggregator::get_next_time() instead of
    a segment position, as required by the API.

    Also only update the segment position after we pushed a buffer, otherwise
    we're going to push down a segment event with the next position already.

    https://bugzilla.gnome.org/show_bug.cgi?id=753196

commit 336ca3207a2ba591107ceba8921ed73957ddd235
Author: Sebastian Dröge <sebastian at centricular.com>
Date:   Fri Sep 11 12:21:50 2015 +0200

    aggregator: Document that get_next_time() should return running time

    https://bugzilla.gnome.org/show_bug.cgi?id=753196

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list