[Bug 754120] avdec_hevc: Segfault in hevc decode with glimagesink and AVX2 CPU feature

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=754120

Matthew Waters <ystreet00 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #311347|none                        |reviewed
             status|                            |

--- Comment #31 from Matthew Waters <ystreet00 at gmail.com> ---
Review of attachment 311347:
 --> (https://bugzilla.gnome.org/review?bug=754120&attachment=311347)

Looks mostly ok to me.

::: gst-libs/gst/gl/gstglmemory.c
@@ +646,3 @@
+  /* update to match max alignment requirement */
+  align_params.align = max_align;
+  mem->valign.stride_align[plane] = max_align;

Why don't we update the entire structure?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.