[Bug 754120] avdec_hevc: Segfault in hevc decode with glimagesink and AVX2 CPU feature

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=754120

Tim-Philipp Müller <t.i.m at zen.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
   Target Milestone|1.6.0                       |1.5.91

--- Comment #35 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
Ok, pushed after further discussion on IRC.

The patches may not be optimal, but they err in favour of being safe. We can
improve things some more and add some utility functions after the release.
There's bug #755068 to track this.

commit 6fadf448de1cfe1b379b0fff8fa3c0f2eb6a4a79
Author: Tim-Philipp Müller <tim at centricular.com>
Date:   Fri Aug 28 09:38:53 2015 +0100

    avvidec: increase default alignment to 32 bytes

    Change default alignment from 16 to 32 bytes, which fixes crashes
    when decoding H.265 using AVX2-based decoder code paths and when
    using ximagesink/glimagesink.

    https://bugzilla.gnome.org/show_bug.cgi?id=754120

commit a0ebef96372a61f8dc658995fb4f1480512b365b
Author: Tim-Philipp Müller <tim at centricular.com>
Date:   Fri Sep 11 23:19:21 2015 +0100

    avvideodec: ensure required mem alignment fixing avdec_h265 crashes with
ximagesink/glimagesink

    Make sure the alignment requirement in GstAllocationParams
    matches the GstVideoAlignment requirements. This fixes
    issues with avdec_h265 crashing in the avx2 code path when
    used with playbin and ximagesink/glimagesink as videosink.

    The internal video pool would allocate buffers with an
    alignment of 15 even though GstVideoAlignment specified
    a stride_align requirement of 31 (which comes from ffmpeg).

    https://bugzilla.gnome.org/show_bug.cgi?id=754120



commit 8b96b52a62567d70ce827db00fd0f50f79133ee5
Author: Tim-Philipp Müller <tim at centricular.com>
Date:   Fri Sep 11 23:36:47 2015 +0100

    videopool: ensure allocation alignment is consistent with video alignment
requirements

    Make sure GstAllocationParams alignment is not less than
    any alignment requirement specified via GstVideoAlignment.

    https://bugzilla.gnome.org/show_bug.cgi?id=754120

commit fe8de1857a704af9ed6160dfdf8f93131e78ba19
Author: Tim-Philipp Müller <tim at centricular.com>
Date:   Tue Sep 15 11:34:12 2015 +0100

    gl: bufferpool take into account video stride alignment requirements

    when allocating memory. Fixes crashes with avdec_h265 in the AVX2
    code path which requires 32-byte stride alignment, but the
    GstAllocationParams only specified a 16-byte alignment.

    https://bugzilla.gnome.org/show_bug.cgi?id=754120

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.