[Bug 752480] dashdemux: negative values for r attribute in S node are not supported

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=752480

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #311385|none                        |needs-work
             status|                            |

--- Comment #22 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 311385:
 --> (https://bugzilla.gnome.org/review?bug=752480&attachment=311385)

::: ext/dash/gstmpdparser.c
@@ +3094,3 @@
+static GstClockTime
+gst_mpdparser_get_end (GstMpdClient * client, GPtrArray * segments,
+    const GstMediaSegment * segment, gint index)

get_end() is a weird name :) What about get_segment_end_time()?

@@ +3128,3 @@
+      GstClockTime start = s->start;
+      GstClockTime end = gst_mpdparser_get_end (client, segments, s, i);
+      repeat = (guint) (end - start) / s->duration;

This might give one repeat too few in case of rounding errors. Should probably
be rounded up?

@@ +3683,3 @@
+        if (in_segment) {
+          selectedChunk = segment;
+          repeat_index = (ts - segment->start) / segment->duration;

Round up?

@@ +3804,3 @@
+     * implicit, as this will all get deleted/recreated), or the
+     * start of the next segment, if any. */
+    if (segment_idx < stream->segments->len - 1) {

Hm, this function is "get_last_fragment_timestamp_end". I assume there can
never ever be another segment then and we always return the period end?

@@ +4164,3 @@
+            stream->segment_index);
+        stream->segment_repeat_index =
+            (guint) (end - start) / segment->duration;

Round up?

@@ +4203,3 @@
+            stream->segment_index);
+        stream->segment_repeat_index =
+            (guint) (end - start) / segment->duration;

Round up?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.