[Bug 711155] wayland: add wl_drm support to wayland sink

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=711155

--- Comment #53 from Benjamin Gaignard <benjamin.gaignard at gmail.com> ---
(In reply to Julien Isorce from comment #52)
> (In reply to Benjamin Gaignard from comment #51)
> > Julien: from this example you give on another bug
> > gst-launch-1.0 filesrc location=video.mp4 ! qtdemux ! h264parse !
> > vaapidecode ! "video/x-raw(memory:VASurface), format=NV12" ! vaapipostproc !
> > "video/x-raw(memory:dmabuf), format=RGBA" ! glimagesink
> > 
> > May I understand that you want to extend filter element to be able to select
> > the allocator in buffer pool ? If it is that and while memory:* do not
> > appear in element src/sink caps it fine for me.
> 
> Which filter ?

This one for example: "video/x-raw(memory:VASurface), format=NV12"
If memory:VASurface is used to check that the pool provide an allocator named
VASurface it is fine for me. If memory:VASurface is used to select a specific
caps 
vaapidecode I think it is wrong.

In gstreamer doc it is clear that allocators are one of the properties
negotiated between elements:
http://cgit.freedesktop.org/gstreamer/gstreamer/tree/docs/design/part-bufferpool.txt#n20


> In this example I just use the caps feature because once it is negotiated it
> can only produce dmabuf. It won't mix different memory types in the same
> flow.
> Note that in this example it is export -> import.
> So upstream element does not need to setup downstream pool in advance.
> 
> Sorry it is not clear to me :), in the end are you in favor of memory:DMABuf
> caps feature ?

No adding memory:dmabuf caps feature will make us duplicate template caps every
where because you link stream format and memory type

> I mean as long as it is still allowed to do it without the
> cas feature. I.e. with add_allocation_param or Nicolas's solution in comment
> #49, for more granularity.
> The caps feature is just there to strictly fix the memory type and to
> advertise in the caps what it can support.

In propose_allocation you can check the caps and put the allocator(s) that
support them. If you have a smart decide_allocation function you can select the
allocator else the first one will used.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.