[Bug 750847] dashdemux: variables containing time information should be guint64 not gint64

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Wed Sep 16 07:44:17 PDT 2015


https://bugzilla.gnome.org/show_bug.cgi?id=750847

--- Comment #13 from Florin Apostol <florin.apostol at oregan.net> ---
Review of attachment 311463:
 --> (https://bugzilla.gnome.org/review?bug=750847&attachment=311463)

::: ext/dash/gstmpdparser.c
@@ +960,3 @@
     exists = TRUE;
     *property_value =
+        (((((gint64) years * 365 + months * 30 + days) * 24 +

years should now be converted to guint64. 
Also years, months, etc should be guint and they should be validated that they
are not negative. Or search for "-" sign and return error if found.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list