[Bug 752714] dashdemux: index information returned by gst_mpd_client_get_next_fragment is not used

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Wed Sep 16 08:43:05 PDT 2015


https://bugzilla.gnome.org/show_bug.cgi?id=752714

--- Comment #10 from Vincent Penquerc'h <vincent.penquerch at collabora.co.uk> ---
Review of attachment 308528:
 --> (https://bugzilla.gnome.org/review?bug=752714&attachment=308528)

::: ext/dash/gstdashdemux.c
@@ +934,3 @@
+    } else {
+      /* header did not configure index, take values from fragment */
+      stream->fragment.index_uri = fragment.index_uri;

I think this might need a strdup. gst_dash_demux_stream_update_headers_info
allocates for stream->fragment.index_uri, and
gst_adaptive_demux_stream_fragment_clear calls g_free. Not super sure though,
as there is some similar code below that does not allocate either...

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list