[Bug 755123] tagdemux: protect internal state for concurrent access

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=755123

--- Comment #3 from GstBlub <gstblub at gmail.com> ---
(In reply to Tim-Philipp Müller from comment #2)
> Thanks for the patch, you might be onto something here, even if at first
> glance it looks like you might be doing a bit more than necessary. Haven't
> looked carefully yet though.
Yeah I'm honestly not sure if what I'm going is necessarily correct, but it
reliably fixed these crashes.  I haven't been able to crash it anymore.  It's a
little ugly, I agree, and maybe using a separate mutex would simplify things,
but I do know for sure that a lot of the ->priv members are accessed/used by
various threads and none of which is protected, resulting in this particular
crash.  I wouldn't be shocked if it also caused some other memory corruption
triggering other bugs down the road.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.