[Bug 750847] dashdemux: variables containing time information should be guint64 not gint64

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=750847

--- Comment #23 from Florin Apostol <florin.apostol at oregan.net> ---
Review of attachment 311537:
 --> (https://bugzilla.gnome.org/review?bug=750847&attachment=311537)

::: ext/dash/gstmpdparser.c
@@ +843,3 @@

+static int
+sscanfu (const char *s, unsigned int *u)

instead of introducing a new function that works only for 32bit integers why
not update the code that requires reading unsigned data to check for the
presence of a "-" sign in the string? After that check we can safely use
sscanf(s, "%u",...) or sscanf (str, "%" G_GUINT64_FORMAT, ...)

For example we add:
if (strchr (str, '-') != NULL) {
  GST_WARNING("'-' sign found while parsing unsigned data");
  goto error;
}

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.