[Bug 752336] dashdemux: duration field could overflow

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=752336

--- Comment #2 from Florin Apostol <florin.apostol at oregan.net> ---
Review of attachment 311556:
 --> (https://bugzilla.gnome.org/review?bug=752336&attachment=311556)

This is so complicated! Just to check if the month is set before the year!
Why not initialize year, month, day to 0 and before assigning year=read you
check if the month or day was set! Easy and clear, you add just 2 ifs, one for
year, one for month. Similar for time.

::: ext/dash/gstmpdparser.c
@@ +917,2 @@
             years = read;
+            if (years > 584) {  /* see
https://bugzilla.gnome.org/show_bug.cgi?id=752336 for rationale */

I don't think we need to limit it like this. We should detect a possible
overflow during the calculation of property_value

@@ +961,3 @@
     pos = 0;
     if (pos < len) {
+      /* T units_found, there is a time section */

why did you changed this? Possible a find and replace error

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.