[Bug 755161] h264parse: initialize slice group id earlier

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=755161

--- Comment #6 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
(In reply to Sebastian Dröge (slomo) from comment #5)
> Why exactly is that crashing though, shouldn't the struct be initialized
> with zeroes or something sensible before passing it there? 

That's the question, and in bug 754845 we discussed it. 

But, as the pointer is set to NULL in the function already, it seems to me
logical that the pointer should be set to NULL before the function could
return, so the a future call to gst_h264_pps_clear() doesn't crash.

> Is the code that uses this just allocating it on the stack without 
> initialization? I would consider that a bug too

Yes, and we already integrated the patch for it in gstreamer-vaapi: 

https://github.com/01org/gstreamer-vaapi/commit/f6ae00a6bb5d55b48fc2074b5abccad0bccee641

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.