[Bug 755247] {track,videotrack,smart-video-mixer}: leaks their internal objects

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=755247

Thibault Saunier <tsaunier at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #311663|none                        |reviewed
             status|                            |

--- Comment #2 from Thibault Saunier <tsaunier at gnome.org> ---
Review of attachment 311663:
 --> (https://bugzilla.gnome.org/review?bug=755247&attachment=311663)

::: ges/ges-smart-video-mixer.c
@@ -205,2 +205,3 @@
   }

+  if (!gst_element_remove_pad (GST_ELEMENT (self), self->srcpad)) {

That should not happen, and we should anyway have the infor from
gst_element_remove_pad  anyway.

::: ges/ges-track.c
@@ +465,3 @@
+    if (priv->nleobject) {
+      if (priv->mixer) {
+        gst_bin_remove (GST_BIN (priv->nleobject), priv->mixer);

That should be done disposing ourself, then recursing down to all the object
contained in it I think, why do you think it is needed here?

@@ -520,2 +534,3 @@
     }

+    self->priv->mixer = gst_object_ref (mixer);

We should not need that, adding the mixer to the nleobject guarantees us we can
use the mixer until we destroy the nleobject.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.