[Bug 755249] gtkglsink: Hide and cleaned the GtkWindow we might create

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=755249

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #311667|none                        |accepted-commit_now
             status|                            |

--- Comment #3 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 311667:
 --> (https://bugzilla.gnome.org/review?bug=755249&attachment=311667)

Looks good, please push after a small change

::: ext/gtk/gstgtkbasesink.c
@@ +287,3 @@
     /* User did not add widget its own UI, let's popup a new GtkWindow to
      * make gst-launch-1.0 work. */
+    gst_sink->window = gtk_window_new (GTK_WINDOW_TOPLEVEL);

This window creation and destruction is IMHO wrong. We're calling this from a
random thread that is starting the sink, not necessarily the GTK main thread.
Please create another bug about this as a reminder

@@ +304,3 @@
+  if (gst_sink->window) {
+    gtk_widget_hide (gst_sink->window);
+    gst_object_unref (gst_sink->window);

A GtkWindow is not a GstObject ;)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.