[Bug 755260] decodebin: Fix a race condition accessing the decode_chain field.

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=755260

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #311671|none                        |reviewed
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 311671:
 --> (https://bugzilla.gnome.org/review?bug=755260&attachment=311671)

I think you found something here that caused a lot of problems in the past,
there should be a few more spurious decodebin2 crash bug reports about this

::: gst/playback/gstdecodebin2.c
@@ +2844,3 @@
+
+    decode_bin->decode_chain = gst_decode_chain_new (decode_bin, NULL, pad);
+    chain = gst_decode_chain_ref (decode_bin->decode_chain);

It's worrying that the chain can get destroyed here if we don't hold the expose
lock. Maybe the code below should be called with some lock held instead so that
shutting down would block on that (e.g. the chain lock)?

Also this is probably not the only problematic place then

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.