[Bug 755326] souphttpclientsink: Fix memory leaks and segfault crash.

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=755326

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #311730|none                        |reviewed
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 311730:
 --> (https://bugzilla.gnome.org/review?bug=755326&attachment=311730)

::: ext/soup/gstsouphttpclientsink.c
@@ +653,3 @@
+  if (souphttpsink->message == NULL) {
+    GST_DEBUG_OBJECT (souphttpsink,
+        "URI could not be parsed while creating message.");

Ideally we should also catch that in set_uri / set_property already, but this
check would still be a good idea on top of that.

You could use GstUri for the validation there

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.