[Bug 755249] gtkglsink: Hide and cleaned the GtkWindow we might create

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=755249

Matthew Waters <ystreet00 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #311734|none                        |reviewed
             status|                            |

--- Comment #9 from Matthew Waters <ystreet00 at gmail.com> ---
Review of attachment 311734:
 --> (https://bugzilla.gnome.org/review?bug=755249&attachment=311734)

Looks fine.

::: ext/gtk/gstgtkbasesink.c
@@ +154,3 @@
+    g_clear_object (&gtk_sink->widget);
+  else
+    gtk_sink->window = NULL;

either make the else clause an else if (widget == gtk_sink->window) with an
else g_assert_not_reached() or make a separate callback for the window destroy.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.