[Bug 755343] funnel: Fix racy state change

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Mon Sep 21 05:14:51 PDT 2015


https://bugzilla.gnome.org/show_bug.cgi?id=755343

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #311748|none                        |reviewed
             status|                            |

--- Comment #3 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 311748:
 --> (https://bugzilla.gnome.org/review?bug=755343&attachment=311748)

::: plugins/elements/gstfunnel.c
@@ +454,2 @@
+      while (res == GST_ITERATOR_OK || res == GST_ITERATOR_RESYNC) {
+        res = gst_iterator_foreach (iter, reset_pad, element);

This looks wrong. Why would you get OK and then iterate again over all pads?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list