[Bug 753613] mssdemux: PlayReady WRM parsing support

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Mon Sep 21 15:25:28 PDT 2015


https://bugzilla.gnome.org/show_bug.cgi?id=753613

Thiago Sousa Santos <thiagossantos at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #310874|none                        |reviewed
             status|                            |

--- Comment #14 from Thiago Sousa Santos <thiagossantos at gmail.com> ---
Review of attachment 310874:
 --> (https://bugzilla.gnome.org/review?bug=753613&attachment=310874)

Looks good overall.

Tim, as you merged the DASH CENC stuff, do you see any issues here or can we
mark this as commit-after-freeze? (after this minor fix)

::: ext/smoothstreaming/gstmssdemux.c
@@ +553,3 @@
+          NULL);
+      gst_structure_set_name (s, "application/x-cenc");
+    }

Would you mind moving this to a function to avoid the repeated code?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list