[Bug 755380] validate:reporter: crash when argument is NULL

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=755380

Thibault Saunier <tsaunier at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #311817|none                        |reviewed
             status|                            |

--- Comment #4 from Thibault Saunier <tsaunier at gnome.org> ---
Review of attachment 311817:
 --> (https://bugzilla.gnome.org/review?bug=755380&attachment=311817)

OK

::: validate/gst/validate/gst-validate-report.c
@@ -411,2 +415,3 @@
 gst_validate_issue_from_id (GstValidateIssueId issue_id)
 {
+  g_return_val_if_fail (issue_id > 0, NULL);

Can't it be 0 too?

@@ -575,3 +587,3 @@
 /**
  * gst_validate_print_action:
- * @action: (allow-none): The source object to log
+ * @action: The source object to log

That makes me think it was on purpose, are you sure?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.