[Bug 755380] validate:reporter: crash when argument is NULL

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=755380

--- Comment #7 from Wonchul Lee <chul0812 at gmail.com> ---
Review of attachment 311817:
 --> (https://bugzilla.gnome.org/review?bug=755380&attachment=311817)

::: validate/gst/validate/gst-validate-report.c
@@ -411,2 +415,3 @@
 gst_validate_issue_from_id (GstValidateIssueId issue_id)
 {
+  g_return_val_if_fail (issue_id > 0, NULL);

issus_id comes from g_quark_from_static_string. If the string is null before
transform it to gquark, then it can be 0.

@@ -575,3 +587,3 @@
 /**
  * gst_validate_print_action:
- * @action: (allow-none): The source object to log
+ * @action: The source object to log

yes, the action value can not be NULL here, so I guessed it had been reversed
though it is not that much useful to pass null to message.
If not, some codes need to be changed.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.