[Bug 755342] element: state_change may fail because of release_request_pad (racy)

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=755342

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #311752|none                        |needs-work
             status|                            |

--- Comment #3 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 311752:
 --> (https://bugzilla.gnome.org/review?bug=755342&attachment=311752)

Looks good but

::: gst/gstelement.c
@@ +2691,3 @@
+    if (GST_PAD_PARENT (pad) != NULL) {
+      cont = FALSE;
+      g_value_set_boolean (ret, FALSE);

Same change needed in gstbin.c (search for gst_pad_set_active())

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.