[Bug 755411] mpdparser: Only check stream->segments for a repeated last segment if we have a static list of segments

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=755411

Thiago Sousa Santos <thiagossantos at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #311853|none                        |reviewed
             status|                            |

--- Comment #2 from Thiago Sousa Santos <thiagossantos at gmail.com> ---
Review of attachment 311853:
 --> (https://bugzilla.gnome.org/review?bug=755411&attachment=311853)

::: ext/dash/gstmpdparser.c
@@ +4755,3 @@

+    if (segments_count > 0 && stream->segments
+        && stream->segment_index + 1 == segments_count) {

Shouldn't segments_count be 0 when stream->segments == NULL?

Fixing the root cause here seems safer.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.