[Bug 754864] qtdemux:check multi trex to find track id in mp4 (DASH) stream.

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=754864

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #311850|none                        |needs-work
             status|                            |

--- Comment #10 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 311850:
 --> (https://bugzilla.gnome.org/review?bug=754864&attachment=311850)

::: gst/isomp4/qtdemux.c
@@ +8450,3 @@
     }
+    /* need defaults for fragments */
+    qtdemux_parse_trex (qtdemux, stream, &dummy, &dummy, &dummy);

Should this maybe be one line below? After the flushing?

@@ -10041,3 @@
           GSTTIME_TO_QTSTREAMTIME (stream, qtdemux->segment.duration);
-    /* need defaults for fragments */
-    qtdemux_parse_trex (qtdemux, stream, &dummy, &dummy, &dummy);

You should remove the dummy declaration from this block. It's unused now.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.