[Bug 750721] tools: gst-play: Print artist/album/title tags

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=750721

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #304992|rejected                    |reviewed
             status|                            |

--- Comment #1 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 304992:
 --> (https://bugzilla.gnome.org/review?bug=750721&attachment=304992)

Makes sense to me, why is this rejected? Should probably print all tags from
the tag messages though, not just these few. See gst-launch code for some code
that prints arbitrary tags

::: tools/gst-play.c
@@ +446,3 @@
+      if (!play->printed_tags) {
+        gchar *str;
+        if (gst_tag_list_get_string (tags, GST_TAG_ARTIST, &str)) {

You're leaking the strings here

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.